From: Steven Smith Subject: Re: [PATCH] Paravirt framebuffer console cleanups [5/5] Date: Wed, 6 Sep 2006 22:27:07 +0100 Message-ID: <20060906212707.GB6898@cam.ac.uk> References: <1157227140.11059.45.camel@aglarond.local> <20060904090228.GE4812@cam.ac.uk> <1157472707.7571.85.camel@aglarond.local> <20060906091832.GG3257@cam.ac.uk> <1157552060.25608.62.camel@aglarond.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1122724621==" Return-path: In-Reply-To: <1157552060.25608.62.camel@aglarond.local> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Katz Cc: xen-devel , Markus Armbruster , sos22@srcf.ucam.org List-Id: xen-devel@lists.xenproject.org --===============1122724621== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0ntfKIWw70PvrIHh" Content-Disposition: inline --0ntfKIWw70PvrIHh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > > > This whole passage is a little peculiar, in that you're only going = to > > > > do anything if use_graphics is disabled. I'd expect that just leav= ing > > > > the current behaviour alone would be the correct thing to do in that > > > > case. > > > >=20 > > > > Also, why do you need to set CON_CONSDEV at all? > > > Otherwise, you don't get kernel console messages. > > Why not? None of the other console drivers seem to need to set it > > explicitly, and it seems like it would break setting console=3Dblah on > > the kernel command line. > Nothing else sets it explicitly because it happens implicitly in the > console registration code for the first thing registered with > register_console(). Alternately, if you have a console=3D, then > register_console ensures that your console device has CON_CONSDEV set. > kernel/printk.c if you want to read all the gory details The intent of this code seems to be to make sure that CON_CONSDEV is definitely set on xenconsole if use_graphics is not set, yes? But as far as I can see, if use_graphics is not set, xenfb should never call register_console(), and so this is all redundant. What am I missing? Steven. --0ntfKIWw70PvrIHh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFE/z0rO4S8/gLNrjcRAqk8AJ9NmQIGBvvlr+yvQnv/YetZKa3RPgCfb7OK yvCn59U3qWyQRslCleREqzc= =LHdo -----END PGP SIGNATURE----- --0ntfKIWw70PvrIHh-- --===============1122724621== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1122724621==--