From: Wolfgang Denk Date: Sat, 09 Sep 2006 00:32:26 +0200 Subject: [U-Boot-Users] [PATCH] Define upmconfig() for 834x systems In-Reply-To: Your message of "Fri, 08 Sep 2006 16:47:03 CDT." <11577520232114-git-send-email-timur@freescale.com> Message-ID: <20060908223226.79375353AD0@atlas.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <11577520232114-git-send-email-timur@freescale.com> you wrote: > > * Define upmconfig() for 834x systems, and hang if called on non-834x systems. > This function programs one of the UPMs with the code passed to it. The > BR and OR for the chosen bank (any bank will do) and the MxMR must all be > programmed correctly before calling this function. I don't see any users for this function. Please don't add dead code. If you intend to use this with any future patches, then please submit your patches in an order that makes some sense. Also, please follow the Coding Style requirements (trailing white space). Best regards, Wolfgang Denk -- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Be careful what you wish for. You never know who will be listening. - Terry Pratchett, _Soul Music_