From: Daniele Palumbo Subject: Re: [Xen-users] Ethernet MTU Date: Wed, 13 Sep 2006 16:55:20 +0200 Message-ID: <200609131655.20244.daniele@retaggio.net> References: <00c801c6c11c$a2c62ee0$2f00a8c0@ELTON> <20060816120908.GC8597@nnx.com> <20060816205306.GA15396@nnx.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060816205306.GA15396@nnx.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-users@lists.xensource.com Cc: xen-devel List-Id: xen-devel@lists.xenproject.org I have some news... On Wednesday 16 August 2006 22:53, Dominique Rousseau wrote: > After some tries, it looks like the vif code don't handle frames > with size larger than 1500. true: http://lists.xensource.com/archives/html/xen-devel/2006-08/msg00944.html > Looking at the code, there is the following snippet that seems to be > the probleme (in drivers/xen/netback/netback.c) : > > if (unlikely(txreq.size < ETH_HLEN) || > unlikely(txreq.size > ETH_FRAME_LEN)) { > DPRINTK("Bad packet size: %d\n", txreq.size); > make_tx_response(netif, txreq.id, NETIF_RSP_ERROR); > netif_put(netif); > continue; > } ./include/linux/if_vlan.h:#define VLAN_ETH_FRAME_LEN 1518 /* Max. octets in frame sans FCS */ ./include/linux/if_ether.h:#define ETH_FRAME_LEN 1514 /* Max. octets in frame sans FCS */ ./include/linux/if_vlan.h:#define VLAN_ETH_HLEN 18 /* Total octets in header. */ ./include/linux/if_ether.h:#define ETH_HLEN 14 /* Total octets in header. */ netfront_vlan.patch: --- # Node ID a5ee1cb525bbe8954dc3332ceec951e09a378b68 # parent: c097485037f7417b77db34da198b62a9c9481dc5 Make MTU rx check in netfront more permissive to allow for 8021q vlan tagging. Signed-off-by: Keir Fraser --- a/linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c Wed Mar 15 12:41:58 2006 +0100 +++ b/linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c Wed Mar 15 12:52:33 2006 +0100 @@ -845,11 +845,11 @@ static int netif_poll(struct net_device } while ((skb = __skb_dequeue(&rxq)) != NULL) { - if (skb->len > (dev->mtu + ETH_HLEN)) { + if (skb->len > (dev->mtu + ETH_HLEN + 4)) { if (net_ratelimit()) printk(KERN_INFO "Received packet too big for " "MTU (%d > %d)\n", - skb->len - ETH_HLEN, dev->mtu); + skb->len - ETH_HLEN - 4, dev->mtu); skb->len = 0; skb->tail = skb->data; init_skb_shinfo(skb); --- looking at all that things, maybe the solutions is to change ETH_FRAME_LEN in VLAN_ETH_FRAME_LEN... or to remove that check (already done in unstable). i'll try tomorrow. bye d.