From: Arnd Bergmann Subject: Re: [RFC] Alignment of fields in struct dentry Date: Fri, 15 Sep 2006 22:44:07 +0200 Message-ID: <200609152244.07889.arnd@arndb.de> References: <20060914093123.GA10431@wohnheim.fh-wedel.de> <20060914215545.GC6441@schatzie.adilger.int> <20060915102736.GA767@wohnheim.fh-wedel.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from moutng.kundenserver.de ([212.227.126.188]:1227 "EHLO moutng.kundenserver.de") by vger.kernel.org with ESMTP id S932238AbWIOUoO convert rfc822-to-8bit (ORCPT ); Fri, 15 Sep 2006 16:44:14 -0400 To: =?iso-8859-1?q?J=F6rn_Engel?= In-Reply-To: <20060915102736.GA767@wohnheim.fh-wedel.de> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Am Friday 15 September 2006 12:27 schrieb J=F6rn Engel: > -}; > +}__attribute__((aligned(64)));=A0/* make sure the dentry is 128/192 = bytes > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0 =A0 on 32/64 bit independently of config > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0 =A0 options. =A0d_iname will vary in length > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0 =A0 a bit. */ I'd guess that a 32 byte alignment is much better here, 64 byte sounds excessive. It should have the same effect with the current dentry layou= t and default config options, but would keep the d_iname length in the 16-44 byte range instead of 16-76 byte as your patch does. Since all important fields are supposed to be kept in 32 bytes anyway, they are still either at the start or the end of a given cache line, but never cross two. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html