From: Horms Subject: Re: [patch 1/3] add type parameter to ip_route_me_harder Date: Wed, 20 Sep 2006 23:17:34 +0900 Message-ID: <20060920141732.GA1286@verge.net.au> References: <20060919024507.458115000@tabatha.lab.ultramonkey.org> <20060919025203.458282000@tabatha.lab.ultramonkey.org> <45111862.2000900@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ken Brownfield , Roberto Nibali , netfilter-devel@lists.netfilter.org, Farid Sarwari , Julian Anastasov , David Black , Joseph Mack NA3T , David Miller Return-path: To: Patrick McHardy Content-Disposition: inline In-Reply-To: <45111862.2000900@trash.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org On Wed, Sep 20, 2006 at 12:30:58PM +0200, Patrick McHardy wrote: > Horms wrote: > > +/* > > + * addr_type: 0 - determine automatically > > + * 1 - local > > + * 2 - non-local > > + */ > > + > > /* route_me_harder function, used by iptable_nat, iptable_mangle + ip_queue */ > > -int ip_route_me_harder(struct sk_buff **pskb) > > +int ip_route_me_harder(struct sk_buff **pskb, unsigned addr_type) > > I liked the RTN_ types better .. is there a reason for not using > them? Otherwise I'll just change it before applying. Mainly because it seemed difficult to shoe-horn into the reworking of ipt_REJECT's reverse_route(). In particular, what value should be passed for non-local? auto and local are of course easy. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/