Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1GQEBI-0005HU-NM for mharc-grub-devel@gnu.org; Wed, 20 Sep 2006 22:20:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GQEBH-0005Gj-5R for grub-devel@gnu.org; Wed, 20 Sep 2006 22:20:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GQEBG-0005GQ-Qz for grub-devel@gnu.org; Wed, 20 Sep 2006 22:20:50 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GQEBG-0005GD-C5 for grub-devel@gnu.org; Wed, 20 Sep 2006 22:20:50 -0400 Received: from [212.85.152.101] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GQEEg-0003aP-0s for grub-devel@gnu.org; Wed, 20 Sep 2006 22:24:22 -0400 Received: from kotoba.oasis.nexedi.com (kotoba.oasis.nexedi.com [212.85.152.101]) by kotoba.storever.com (Postfix) with ESMTP id A35DF3CBF63E4 for ; Thu, 21 Sep 2006 06:17:41 +0200 (CEST) Received: from [??1] (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 2D27B3CBF63E3 for ; Thu, 21 Sep 2006 06:17:41 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Thu, 21 Sep 2006 03:55:54 +0200 User-Agent: KMail/1.8.2 References: <20060917203924.GA3073@khazad.dyndns.org> In-Reply-To: <20060917203924.GA3073@khazad.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200609210355.54781.okuji@enbug.org> X-Bogosity: No, tests=bogofilter, spamicity=0.499998, version=0.17.2 Subject: Re: [PATCH] don't abort with error if realpath fails X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2006 02:20:51 -0000 On Sunday 17 September 2006 22:39, Robert Millan wrote: > Please consider (mostly useful to support device.map generated by GRUB > legacy): > > 2006-09-17 Robert Millan > > * util/i386/pc/biosdisk.c (read_device_map): Don't abort with error if > realpath fails (e.g. to cope with missing /dev/fd0 when we're aren't > writing to floppy). Can you elaborate on the purpose? Personally I prefer a strict check for this part, since the installation of GRUB is potentially very dangerous! Okuji