From: Muli Ben-Yehuda Subject: Re: [PATCH] fix build of gdbstub.c Date: Tue, 26 Sep 2006 08:56:56 +0300 Message-ID: <20060926055656.GD20797@rhun.haifa.ibm.com> References: <4517F8E4.D169.003C.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4517F8E4.D169.003C.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Charles Coffing Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, Sep 25, 2006 at 05:44:30PM -0400, Charles Coffing wrote: > Changeset 11598 broke the build with my gcc-4.1.2. You can't > forward-declare a static function within another function. Trivial > patch attached to fix this. While you're in there, it would be nice to do this right and move the declaration to a header file so that it doesn't eventually (but certainly) get out of sync... Cheers, Muli