From: Jeff Garzik Subject: [PATCH] SCSI: shift device_reprobe() warning explosion Date: Wed, 27 Sep 2006 21:08:24 -0400 Message-ID: <20060928010824.GA26438@havoc.gtf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from havoc.gtf.org ([69.61.125.42]:45522 "EHLO havoc.gtf.org") by vger.kernel.org with ESMTP id S964979AbWI1BIY (ORCPT ); Wed, 27 Sep 2006 21:08:24 -0400 Content-Disposition: inline Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Linus Torvalds Cc: LKML , linux-scsi@vger.kernel.org SCSI warns about device_reprobe() for _every file_, even though there is only a single caller in the entirety of SCSI. The need to check return code is valid, so we update the warning area to shift the burden to the [only] caller, mptsas. Signed-off-by: Jeff Garzik diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 895d212..b401c82 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -298,9 +298,9 @@ extern int scsi_execute_async(struct scs void (*done)(void *, char *, int, int), gfp_t gfp); -static inline void scsi_device_reprobe(struct scsi_device *sdev) +static inline int __must_check scsi_device_reprobe(struct scsi_device *sdev) { - device_reprobe(&sdev->sdev_gendev); + return device_reprobe(&sdev->sdev_gendev); } static inline unsigned int sdev_channel(struct scsi_device *sdev)