From: Andrew Morton Subject: Re: [PATCH] Fix up a multitude of ACPI compiler warnings on x86_64 Date: Fri, 29 Sep 2006 16:38:27 -0700 Message-ID: <20060929163827.d77a12c8.akpm@osdl.org> References: <451D9236.6040902@google.com> <20060929150526.38eec941.akpm@osdl.org> <20060929161852.4b6ae44a.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.osdl.org ([65.172.181.4]:5516 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1030200AbWI2Xid (ORCPT ); Fri, 29 Sep 2006 19:38:33 -0400 In-Reply-To: <20060929161852.4b6ae44a.rdunlap@xenotime.net> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Randy Dunlap Cc: len.brown@intel.com, Martin Bligh , LKML , linux-acpi@vger.kernel.org On Fri, 29 Sep 2006 16:18:52 -0700 Randy Dunlap wrote: > > > > acpi-fix-printk-format-warnings.patch was submitted to the ACPI developers > > on August 14 and on September 25 but remains unmerged. > > Len and I discussed that patch some. The question about it is: > why does gcc report this at all? Is this a gcc problem or are > we misreading it somehow? > > drivers/acpi/tables/tbget.c: In function 'acpi_tb_get_this_table': > drivers/acpi/tables/tbget.c:326: warning: format '%X' expects type 'unsigned int', but argument 5 has type 'long unsigned int' > > drivers/acpi/tables/tbrsdt.c: In function 'acpi_tb_validate_rsdt': > drivers/acpi/tables/tbrsdt.c:189: warning: format '%X' expects type 'unsigned int', but argument 5 has type 'long unsigned int' > > Why does it think that sizeof(struct X) is long unsigned int? > (and only on 64-bit) hm, strange. No warning at all on 32-bit. Don't know. But the patch is correct.