From: Christoph Hellwig Subject: Re: fscache review comments, part 1 Date: Mon, 2 Oct 2006 22:41:47 +0100 Message-ID: <20061002214147.GC27561@infradead.org> References: <20060928164529.GA3497@infradead.org> <20489.1159796454@warthog.cambridge.redhat.com> <20061002103900.5b239d9f.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Howells , Christoph Hellwig , linux-fsdevel@vger.kernel.org, Trond Myklebust Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:15062 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S965418AbWJBVmL (ORCPT ); Mon, 2 Oct 2006 17:42:11 -0400 To: Andrew Morton Content-Disposition: inline In-Reply-To: <20061002103900.5b239d9f.akpm@osdl.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Oct 02, 2006 at 10:39:00AM -0700, Andrew Morton wrote: > On Mon, 02 Oct 2006 14:40:54 +0100 > David Howells wrote: > > > Christoph Hellwig wrote: > > > > > Unfortunately there's a lot of broken userspace that can't deal > > > with 64bit inode numbers, so you need to make the lod behaviour > > > a mount option at least, probably even the default. Given that > > > we're going to run into problems like that it might make sense > > > to make the option VFS-level instead of just in nfs. (Note: > > > XFS already has an option like that) > > > > This really needs fixing quite urgently. We've seen it break ld.so/libdl (and > > other things, but dynamic loading is one of the major pains as it's not > > entirely obvious). > > > > Speaking of which.. I've been having struggling a bit with > > vfs-make-filldir_t-and-struct-kstat-deal-in-64-bit-inode-numbers.patch > nfs-represent-64-bit-fileids-as-64-bit-inode-numbers-on-32-bit-systems.patch Well, that's the two patches I've commented on above :) > I don't have a good understanding of what the implications are for userspace. > What are the risks and what are the advantages and what the level of urgency > is behind those patches. vfs-make-filldir_t-and-struct-kstat-deal-in-64-bit-inode-numbers.patch is perfectly fine and harmless, seems fine for 2.6.19. nfs-represent-64-bit-fileids-as-64-bit-inode-numbers-on-32-bit-systems.patch is quite risky as I mentioned so I'd drop it for the time beeing - we shouldn't put it in as long as we don't have a mount option for it.