From: Wolfgang Denk Date: Thu, 05 Oct 2006 17:57:45 +0200 Subject: [U-Boot-Users] [PATCH] Set fileaddr and filesize environment variables upon download of a file In-Reply-To: Your message of "Wed, 20 Sep 2006 10:42:12 +0200." <200609201042.12600.laurent.pinchart@tbox.biz> Message-ID: <20061005155745.CFB3B353C4D@atlas.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <200609201042.12600.laurent.pinchart@tbox.biz> you wrote: > > load-from-disk commands set the fileaddr and filesize environment variables > upon completion. This patch adds the same functionality for load-from-network > commands (BOOTP, TFTP, NFS, ...). I reject your patch, as it is redundant. > The fileaddr environment variable is set to the address at which the file has This is redundant. The information is already available in the loadaddr environment variable. > been loaded. The filesize environment variable is set to the size of the file > in bytes. This is redundant. The filesize variable already gets set by the current code. Best regards, Wolfgang Denk -- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Einstein argued that there must be simplified explanations of nature, because God is not capricious or arbitrary. No such faith comforts the software engineer. - Fred Brooks, Jr.