From: Mark Williamson Subject: Re: Trying to cause a writepage from commit_write? Date: Thu, 5 Oct 2006 16:57:44 +0100 Message-ID: <200610051657.45365.mark.williamson@cl.cam.ac.uk> References: <200610041534.04743.mark.williamson@cl.cam.ac.uk> <200610042142.58851.mark.williamson@cl.cam.ac.uk> <1159995922.5848.124.camel@lade.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Martin Jambor , linux-fsdevel@vger.kernel.org Return-path: Received: from ppsw-2.csi.cam.ac.uk ([131.111.8.132]:44218 "EHLO ppsw-2.csi.cam.ac.uk") by vger.kernel.org with ESMTP id S1751640AbWJEP5j (ORCPT ); Thu, 5 Oct 2006 11:57:39 -0400 To: Trond Myklebust In-Reply-To: <1159995922.5848.124.camel@lade.trondhjem.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi Trond, Thanks for your reply! > > > 4) Check that writepages() does not kick in earlier and does not do > > > the job instead. > > > > I'm not implementing a writepages() method either, at the moment. > > In that case have you remembered to set 'generic_writepages' as your > default writepages callback? I tried that, and thought it fixed the problem but have been unable to reproduce the correct behaviour. I've now hooked in a custom writepages() implementation that just printks and returns - it doesn't appear to get called. I know I'm dirtying the page on commit_write, and sync is writing out the inode. But it doesn't look like I'm receiving any callbacks to actually write out the data. By the looks of page-writeback.c::do_writepages() if there isn't a specified writepages method, it'll fall back to the generic implementation anyhow, so I don't think this can have been my problem. It looks like do_writepages isn't ever being reached, for some reason. Maybe I'm missing something obvious... Cheers, Mark -- Dave: Just a question. What use is a unicyle with no seat? And no pedals! Mark: To answer a question with a question: What use is a skateboard? Dave: Skateboards have wheels. Mark: My wheel has a wheel!