From: Christoph Hellwig Subject: Re: fscache review comments, part 1 Date: Tue, 10 Oct 2006 14:31:03 +0100 Message-ID: <20061010133103.GA31268@infradead.org> References: <20060928164529.GA3497@infradead.org> <12599.1160401600@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , akpm@osdl.org, linux-fsdevel@vger.kernel.org, torvalds@osdl.org Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:48092 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1750757AbWJJNbJ (ORCPT ); Tue, 10 Oct 2006 09:31:09 -0400 To: David Howells Content-Disposition: inline In-Reply-To: <12599.1160401600@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Oct 09, 2006 at 02:46:40PM +0100, David Howells wrote: > Christoph Hellwig wrote: > > > 05-release-page.diff: > > ACK, though I'd wish someone could come up with nicer names for > > read_cache_pages_invalidate_page(s). > > They could always be nested:-). That way they don't pollute the namespace. > This is one of the gcc extensions. If you do nm on the output, you see the > nested function appear like this if not inlined: > > 000000000000058f t invalidate_page.17245 > > That above derives from this: This is C, not pascal - please don't do such fugly things..