From: John Levon Subject: Re: [PATCH] Fix tools build on Solaris Date: Tue, 17 Oct 2006 14:39:45 +0100 Message-ID: <20061017133945.GA7579@totally.trollied.org> References: <20061017131119.GC6012@totally.trollied.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, Oct 17, 2006 at 02:31:46PM +0100, Keir Fraser wrote: > > Many of the tools use C99 features such as bool, or expect certain functions. > > Fix the CFLAGS to enable these on Solaris. > > > > Signed-off-by: John Levon > > Can't you fold TOOL_CFLAGS into CFLAGS? Why do you need a separate variable: > does it break the hypervisor build? Yes. It's not at all clear why, but the -std=gnu99 causes: gcc -O1 -fno-omit-frame-pointer -g -std=gnu99 -D_POSIX_C_SOURCE=200112L -D__EXTENSIONS__ -Wa,--divide -m64 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -nostdinc -fno-builtin -fno-common -fno-strict-aliasing -iwithprefix include -Werror -Wno-pointer-arith -pipe -I/export/johnlev/xen/xen-unstable-daily/xen.hg/xen/include -I/export/johnlev/xen/xen-unstable-daily/xen.hg/xen/include/asm-x86/mach-generic -I/export/johnlev/xen/xen-unstable-daily/xen.hg/xen/include/asm-x86/mach-default -msoft-float -mno-red-zone -fpic -fno-reorder-blocks -fno-asynchronous-unwind-tables -g -D__XEN__ -DVERBOSE -c domctl.c -o domctl.o domctl.c: In function `do_domctl': domctl.c:173: error: initializer element is not constant regards john