From: John Levon Subject: Re: [PATCH] fix asm syntax Date: Tue, 17 Oct 2006 16:42:55 +0100 Message-ID: <20061017154255.GA12609@totally.trollied.org> References: <20061017134008.GB7579@totally.trollied.org> <20061017151544.GA11816@totally.trollied.org> <453513EC.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <453513EC.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, Oct 17, 2006 at 04:33:32PM +0100, Jan Beulich wrote: > >However, I don't think there's a disadvantage to the more compatible > >syntax, is there? > > While not producing bad side effects here (as Keir convinced me), it is > generally wrong (i.e. it would work right only because of the more than > odd constraint on the operand, which are needed to work around a > quirk in the assembler that was fixed about ten months ago). However, > the / prefix separation in general has been supported for far more than > a year, so I wonder what specific problem you were seeing (and with > how old an assembler)... The standard GNU ld is currently still 2.15 on Solaris. If there's serious objections to not using the newer syntax, we can always keep it as a local hack until we've updated. We're releasing our sources after all. regards, john