From: John Levon Subject: Re: [PATCH] Don't attempt to build kernels on Solaris. Date: Tue, 17 Oct 2006 18:08:40 +0100 Message-ID: <20061017170840.GA16211@totally.trollied.org> References: <20061017163856.GA14583@totally.trollied.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, Oct 17, 2006 at 05:58:46PM +0100, Keir Fraser wrote: > >> Doesn't empty XKERNELS variable get you this for free? I thought that was > >> the point of moving KERNELS/XKERNELS to Linux.mk. > > > > We need this as well because of things like: > > > > for i in $(XKERNELS) ; do $(MAKE) $$i-prep || exit 1; done > > But bash can handle empty lists. If XKERNELS is empty the above should be a > no-op, right? Certainly seems to have that behaviour for me. Ah. This patch obviously predates the "use bash for SHELL" one. You're right, it's not necessary, and can be dropped. thanks john