From: John Levon Subject: Re: [PATCH] compile fix for RING_HAS_UNCONSUMED_REQUESTS Date: Tue, 17 Oct 2006 19:08:05 +0100 Message-ID: <20061017180805.GA18997@totally.trollied.org> References: <20061017132953.GA7307@totally.trollied.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, Oct 17, 2006 at 07:02:35PM +0100, Keir Fraser wrote: > > # Parent a58e7e6dde6b1f6094ea07917b3db794082c409b > > fixes to compile ring.h on solaris with Sun's cc > > I like the gcc syntax so I'll take the patch version of that macro as a > non-GNUC alternative, so both live in the upstream header file. I'm not > taking the chunk with the mb/wmb definitions for Solaris. It's up to the > user of this public header file to provide suitable definitions external to > this header file. OK, sure. thanks, john