From: Horms Subject: Re: [PATCH 01/04] Kexec / Kdump: Generic code Date: Wed, 18 Oct 2006 10:00:05 +0900 Message-ID: <20061018010003.GC11422@verge.net.au> References: <20061017012519.GH29719@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Ian Pratt , Kazuo Moriwaka , xen-devel@lists.xensource.com, Akio Takebe , magnus.damm@gmail.com, Isaku Yamahata , Magnus Damm List-Id: xen-devel@lists.xenproject.org On Tue, Oct 17, 2006 at 07:56:37AM +0100, Keir Fraser wrote: > > > > On 17/10/06 2:25 am, "Horms" wrote: > > > TYPE_DEFAULT is kexec, TYPE_CRASH is kdump. > > > > Its just to avoid a from_guest. If you think that isn't worthwhile > > we can fold it into the structural parameter. > > Yes please. This isn't performance critical. Folding will make the interface > better match other hypercalls. The main thing that I am concerned about is, that in the case that dom0 panics, and we are asking the hypercall to take a dump for us, do we really want a copy_from guest in that path? It seems to me that its best to have that path as simple as possible. But I do argree that it comes at the expense of making the interface a bit unclean. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/