From: Andrew Morton Subject: Re: fsstack: struct path Date: Wed, 18 Oct 2006 01:31:03 -0700 Message-ID: <20061018013103.4ad6311a.akpm@osdl.org> References: <20061018042323.GA8537@filer.fsl.cs.sunysb.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, hch@infradead.org, viro@ftp.linux.org.uk, mhalcrow@us.ibm.com, penberg@cs.helsinki.fi, linux-fsdevel@vger.kernel.org Return-path: Received: from smtp.osdl.org ([65.172.181.4]:52121 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750866AbWJRIee (ORCPT ); Wed, 18 Oct 2006 04:34:34 -0400 To: Josef Sipek In-Reply-To: <20061018042323.GA8537@filer.fsl.cs.sunysb.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 18 Oct 2006 00:23:23 -0400 Josef Sipek wrote: > Few weeks ago, I noticed that fs/namei.c defines struct path: > > struct path { > struct vfsmount *mnt; > struct dentry *dentry; > }; > > I think it would make sense to move it into include/linux/ as it is quite > useful (and it would discourage the (ab)use of struct nameidata.) > > The fsstack code could benefit from it as the stackable fs dentries have to > keep track of the lower dentry as well as the lower vfsmount. > > One, rather unfortunate, fact is that struct path is also defined in > include/linux/reiserfs_fs.h as something completely different - reiserfs > specific. > > Any thoughts? > reiserfs is being bad. s/path/reiserfs_path/g