From: Al Viro Subject: Re: fsstack: struct path Date: Wed, 18 Oct 2006 10:06:23 +0100 Message-ID: <20061018090623.GK29920@ftp.linux.org.uk> References: <20061018042323.GA8537@filer.fsl.cs.sunysb.edu> <20061018013103.4ad6311a.akpm@osdl.org> <20061018013551.3745e1d5.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Josef Sipek , linux-kernel@vger.kernel.org, hch@infradead.org, mhalcrow@us.ibm.com, penberg@cs.helsinki.fi, linux-fsdevel@vger.kernel.org Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:59831 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1751450AbWJRJG1 (ORCPT ); Wed, 18 Oct 2006 05:06:27 -0400 To: Andrew Morton Content-Disposition: inline In-Reply-To: <20061018013551.3745e1d5.akpm@osdl.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Oct 18, 2006 at 01:35:51AM -0700, Andrew Morton wrote: > On Wed, 18 Oct 2006 01:31:03 -0700 > Andrew Morton wrote: > > > > One, rather unfortunate, fact is that struct path is also defined in > > > include/linux/reiserfs_fs.h as something completely different - reiserfs > > > specific. > > > > > > Any thoughts? > > > > > > > reiserfs is being bad. s/path/reiserfs_path/g > > There's also drivers/md/dm-mpath.h's struct path. Renaming fs/namei.c's > `struct path' to `struct namei_path' would be prudent. Yuck... If we really want to switch to it (and I can give you a dozen examples of possible users right now - starting with struct file), putting namei_ into it is both uninformative and ugly. I'm not sure what would be the good name here; "pathname" comes to mind, but it suggests that we are dealing with a string. And "location" is too vague (and probably would cause fsckloads of conflicts itself). Suggestions? "pathname" would almost work; the difference is that this is not a string but a node in tree that string resolves to.