From: Chris Mason Subject: Re: fsstack: struct path Date: Wed, 18 Oct 2006 10:38:10 -0400 Message-ID: <20061018143810.GB16570@think.oraclecorp.com> References: <20061018042323.GA8537@filer.fsl.cs.sunysb.edu> <20061018013103.4ad6311a.akpm@osdl.org> <20061018083527.GJ29920@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Josef Sipek , linux-kernel@vger.kernel.org, hch@infradead.org, mhalcrow@us.ibm.com, penberg@cs.helsinki.fi, linux-fsdevel@vger.kernel.org Return-path: Received: from agminet01.oracle.com ([141.146.126.228]:57826 "EHLO agminet01.oracle.com") by vger.kernel.org with ESMTP id S1161039AbWJROiq (ORCPT ); Wed, 18 Oct 2006 10:38:46 -0400 To: Al Viro Content-Disposition: inline In-Reply-To: <20061018083527.GJ29920@ftp.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Oct 18, 2006 at 09:35:27AM +0100, Al Viro wrote: > On Wed, Oct 18, 2006 at 01:31:03AM -0700, Andrew Morton wrote: > > > One, rather unfortunate, fact is that struct path is also defined in > > > include/linux/reiserfs_fs.h as something completely different - reiserfs > > > specific. > > > > > > Any thoughts? > > > > > > > reiserfs is being bad. s/path/reiserfs_path/g > > Indeed. That's one pending patch that never got around to be submitted > (and had bitrotten at least 3 times, IIRC). > > ACK, provided that reiserfs folks are OK with the replacement name for > their struct. Note that "path" in question has very little to do with > pathnames - it's a path in balanced tree, IIRC. So if we get around > to renaming that sucker, it might be a good time to pick better name. Aside from having to reindent the reiserfs tree afterwards, I doubt anyone would mind (please cc reiserfs-dev on the patch though). Al is right, it's a path in the balanced tree. -chris