From: David Miller Subject: Re: [PATCH] atm: fix horizon init section usage Date: Sun, 22 Oct 2006 20:39:22 -0700 (PDT) Message-ID: <20061022.203922.130845181.davem@davemloft.net> References: <20061022191309.73e3eacd.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, chas@cmf.nrl.navy.mil Return-path: Received: from dsl027-180-168.sfo1.dsl.speakeasy.net ([216.27.180.168]:13258 "EHLO sunset.davemloft.net") by vger.kernel.org with ESMTP id S1751382AbWJWDjU (ORCPT ); Sun, 22 Oct 2006 23:39:20 -0400 To: randy.dunlap@oracle.com In-Reply-To: <20061022191309.73e3eacd.randy.dunlap@oracle.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Randy Dunlap Date: Sun, 22 Oct 2006 19:13:09 -0700 > From: Randy Dunlap > > hrz_init() is called from the probe function, which is __devinit > and could be called after init. > > WARNING: drivers/atm/horizon.o - Section mismatch: reference to .init.text:.hrz_init from .text between '.hrz_probe' (at offset 0x4054) and '.hrz_remove_one' > > Signed-off-by: Randy Dunlap It is only called from hrz_init() and thus shouldn't it be thus marked __devinit as well? That seems to be the right way to fix this one.