From: "guomingyang" Subject: I think I find a bug in ext3/dir.c Date: Tue, 31 Oct 2006 20:23:55 +0800 Message-ID: <200610311235.k9VCZZHv002689@nrchpc.ac.cn> Reply-To: guomingyang@nrchpc.ac.cn Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: 7bit Return-path: Received: from [159.226.39.252] ([159.226.39.252]:53901 "EHLO nrchpc.ac.cn") by vger.kernel.org with ESMTP id S1161649AbWJaMYA (ORCPT ); Tue, 31 Oct 2006 07:24:00 -0500 Received: from ict-df269451790 ([159.226.39.251]) by nrchpc.ac.cn (8.12.5/8.12.5) with ESMTP id k9VCZZHv002689 for ; Tue, 31 Oct 2006 20:35:36 +0800 To: "linux-fsdevel@vger.kernel.org" Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hello everyone I think I find a bug in ext3_readdir if (err > 0) { page_cache_readahead(sb->s_bdev->bd_inode->i_mapping, &filp->f_ra, filp, map_bh.b_blocknr >> (PAGE_CACHE_SHIFT - inode->i_blkbits), 1); bh = ext3_bread(NULL, inode, blk, 0, &err); } map_bh.b_blocknr is the physical number of a block, but page_cache_readahead need a file-relative block number, am I right?