From: Ewan Mellor Subject: Re: [PATCH] xm-test: don't export RD_PATH into TENV Date: Thu, 2 Nov 2006 23:06:17 +0000 Message-ID: <20061102230617.GA30696@leeni.uk.xensource.com> References: <20061101225949.GP12095@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20061101225949.GP12095@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ryan Harper Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wed, Nov 01, 2006 at 04:59:49PM -0600, Ryan Harper wrote: > xm-test currently exports the RD_PATH value into the environment which > prevents one from providing the value when running a test. Without this > patch, one has to re-run ./autogen && ./configure with RD_PATH defined > to change the RD_PATH value that is used. > > Additionally, the current getRdPath() implementation already uses the > the value that was being exported. In short, exporting the value is not > needed unless one wants to override the default value. > > With the patch, the following now works: > > % cp xm-test/ramdisk/initrd.img /boot > % cd xm-test/tests/create > % RD_PATH=/boot TEST_VERBOSE=1 make TESTS=01_create_basic_pos.test check Applied, thanks Ryan. Ewan.