From: Thomas Klein Subject: [PATCH 2.6.19-rc4 1/3] ehea: Nullpointer dereferencation fix Date: Fri, 3 Nov 2006 17:47:20 +0100 Message-ID: <200611031747.21667.osstklei@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev , "linux-kernel" , "linux-ppc" , "Christoph Raisch" , "Jan-Bernd Themann" , "Jan-Bernd Themann" , Marcus Eder , "Thomas Klein" Return-path: Content-Disposition: inline To: Jeff Garzik Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Fix: Must check for nullpointer before dereferencing it - not afterwards. Signed-off-by: Thomas Klein --- diff -Nurp git.netdev-2.6.base/drivers/net/ehea/ehea_qmr.c git.netdev-2.6/drivers/net/ehea/ehea_qmr.c --- git.netdev-2.6.base/drivers/net/ehea/ehea_qmr.c 2006-11-03 14:19:51.000000000 +0100 +++ git.netdev-2.6/drivers/net/ehea/ehea_qmr.c 2006-11-03 14:27:53.000000000 +0100 @@ -209,11 +209,11 @@ int ehea_destroy_cq(struct ehea_cq *cq) { u64 adapter_handle, hret; - adapter_handle = cq->adapter->handle; - if (!cq) return 0; + adapter_handle = cq->adapter->handle; + /* deregister all previous registered pages */ hret = ehea_h_free_resource(adapter_handle, cq->fw_handle); if (hret != H_SUCCESS) {