From: Ewan Mellor Subject: Re: [PATCH] fix xend not to parse `df` Date: Thu, 9 Nov 2006 23:20:05 +0000 Message-ID: <20061109232005.GA6036@leeni.uk.xensource.com> References: <20061109230655.GA24273@totally.trollied.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20061109230655.GA24273@totally.trollied.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: John Levon Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, Nov 09, 2006 at 11:06:55PM +0000, John Levon wrote: > > # HG changeset patch > # User john.levon@sun.com > # Date 1163113431 28800 > # Node ID 348c6ec90131ddfe893029fa01dc133bbc77a3ae > # Parent d6902275432c8570835d0e962ac7991fcd2c070a > Parsing 'df' output is extremely non-portable. Replace with a direct statvfs(). > > Signed-off-by: John Levon Not that I object to your patch (I don't, and will apply it in the morning) but is df non-portable even when specifying the -P flag (POSIX / portability, according to my man page)? Ewan.