From: Randy Dunlap Date: Mon, 20 Nov 2006 15:35:28 -0800 Subject: [Cluster-devel] Re: [PATCH 2.6.19-rc5-mm2] fs/dlm: fix recursive dependency in Kconfig In-Reply-To: <20061120174509.GW31879@stusta.de> References: <456179F6.1060501@redhat.com> <45619547.5070301@s5r6.in-berlin.de> <20061120174509.GW31879@stusta.de> Message-ID: <20061120153528.5ace6089.randy.dunlap@oracle.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, 20 Nov 2006 18:45:09 +0100 Adrian Bunk wrote: > On Mon, Nov 20, 2006 at 12:45:11PM +0100, Stefan Richter wrote: > >... > > Anyway. Whatever you chose to do (or already have chosen to do) in > > fs/dlm/Kconfig, keep in mind that the "select" keyword is presently only > > poorly supported by the various .config generators and that it forces UI > > considerations into the Kconfig files which should better not be > > overloaded with UI issues. Or in other words: It is rather easy to write > > correct and well-supported Kconfig files if you stick with "depend on", > > but you get into trouble fast with generous usage of "select". > > For variables like NET or INET it doesn't matter in practice whether you > use "select" or "depends on". But for other variables it makes it really > hard for users to enable an option if you use "depends on". Doing a "select" NET or INET enables a ton of code, which IMO should be done explicitly, not covertly by a select. --- ~Randy