From: David Miller Subject: Re: [PATCH] irlan: fix header build warning Date: Wed, 06 Dec 2006 20:10:24 -0800 (PST) Message-ID: <20061206.201024.75446456.davem@davemloft.net> References: <20061206114407.9b835a7a.randy.dunlap@oracle.com> <20061206.165717.21938171.davem@davemloft.net> <20061206170818.86c355cb.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, samuel@sortiz.org Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:46785 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S968704AbWLGEKN (ORCPT ); Wed, 6 Dec 2006 23:10:13 -0500 To: randy.dunlap@oracle.com In-Reply-To: <20061206170818.86c355cb.randy.dunlap@oracle.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Randy Dunlap Date: Wed, 6 Dec 2006 17:08:18 -0800 > On Wed, 06 Dec 2006 16:57:17 -0800 (PST) David Miller wrote: > > > How about we protect these function externs with CONFIG_PROC_FS ifdefs > > instead? > > Sure. > > --- > From: Randy Dunlap > > Fix compile warning when CONFIG_PROC_FS=n: > > include/net/irda/irlan_filter.h:31: warning: 'struct seq_file' declared inside parameter list > include/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you want > > Signed-off-by: Randy Dunlap Looks great, applied.