From: Ewan Mellor Subject: Re: [PATCH] Scrub VNC passwords from XenD log files Date: Wed, 6 Dec 2006 17:24:36 +0000 Message-ID: <20061206172435.GA30076@leeni.uk.xensource.com> References: <20061205193125.GF21067@redhat.com> <20061206122520.GE17323@leeni.uk.xensource.com> <20061206171603.GA13126@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20061206171603.GA13126@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Daniel P. Berrange" Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wed, Dec 06, 2006 at 05:16:03PM +0000, Daniel P. Berrange wrote: > I didn't add the signed-off-by because the patch isn't finished - I really > just wanted to see if people were amenable to this kind of approach before > doing more work on it. Since you like it, I'll finish it off shortly - there > just a couple more test cases I need to go through - suspend/restore & inactive > domains - to verify passwords are always scrubbed correctly. I'll post a final > version of the patch by the end of today if all goes to plan. Great, thanks. I think you're right that this is the best of all the available options, fiddly though it is. Perhaps we could write a final check at the end of xm-test, to make sure that "vncpasswd" doesn't appear in the logs anywhere -- that would make sure that this never regresses. Ewan.