From: Ewan Mellor Subject: Re: [Patch] tweak error reporting for bootloader errors in xm Date: Thu, 7 Dec 2006 12:10:59 +0000 Message-ID: <20061207121059.GD30076@leeni.uk.xensource.com> References: <20061106151430.GA9932@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20061106151430.GA9932@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Daniel P. Berrange" Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, Nov 06, 2006 at 03:14:33PM +0000, Daniel P. Berrange wrote: > The xm command does some basic validation of the 'bootloader' parameter > before trying to run it, however, the level of detail reported isn't as > clear as it could be. > > For example if I typo the bootloader param it says: > > # xm create XenGuest1 > Using config file "XenGuest1". > Error: Bootloader isn't executable > > The attached patch makes it do an explicit check for path existance prior > to the one for executable permissions. It also prints out the path being > tested. > > # xm create XenGuest1 > Using config file "XenGuest1". > Error: Bootloader '/usr/sbin/pygrub' does not exist > > > Signed-off-by: Daniel P, Berrange Applied, thanks, and sorry for the delay. Ewan.