From: Ewan Mellor Subject: Re: [PATCH] [xend] Host.get_resident_VMs RPC Date: Wed, 13 Dec 2006 14:44:54 +0000 Message-ID: <20061213144454.GD22851@leeni.uk.xensource.com> References: <457DBACC.6000206@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <457DBACC.6000206@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jim Fehlig Cc: Xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, Dec 11, 2006 at 01:08:44PM -0700, Jim Fehlig wrote: > I've noticed that Host.get_resident_VMs RPC returns duplicate references > to running VMs. Is this the intent or a bug :-)? In XendDomain.py we have > > def get_domain_refs(self): > result = [] > try: > self.domains_lock.acquire() > result = [d.get_uuid() for d in self.domains.values()] > result += self.managed_domains.keys() > return result > finally: > self.domains_lock.release() > > and as you can see a running domain would be included twice in the > resulting list. If this is a bug, patch attached. If intentional, > please let me know so I can handle it appropriately in client code. > > Regards, > Jim > # HG changeset patch > # User jfehlig@jfehlig2.provo.novell.com > # Date 1165867640 25200 > # Node ID 687e576ee99eb68d10324d0013bfd9acc372468c > # Parent 37141c3a3d39956ad5faf2d4e2a91276eaca557b > When enumerating VMs resident on a host (Host.get_resident_VMs RPC), ensure VMs with same UUID only appear once in the list. > > Signed-off-by: Jim Fehlig That wasn't the intention, no! I've applied that, thanks Jim. Ewan.