From: Ewan Mellor Subject: Re: [PATCH] Fix error message when detaching block devices Date: Sat, 16 Dec 2006 12:54:01 +0000 Message-ID: <20061216125401.GA1361@leeni.uk.xensource.com> References: <1166244366.7975.7.camel@941e-2.watson.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1166244366.7975.7.camel@941e-2.watson.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefan Berger Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Fri, Dec 15, 2006 at 11:46:06PM -0500, Stefan Berger wrote: > An error occurs if the first detach was successful and the 2nd one is > not (of course). Return if the 1st detach is successful, try the 2nd one > if it was not successful. Throw an error if the 2nd one fails. > This should also fix problems I am currently seeing in the xm-test > suite. > > Signed-off-by: Stefan Berger I've applied this, because it looks perfectly sensible, but I'm concerned that this failure isn't showing up in our xm-test runs. What failure are you seeing? Ewan.