From: Josef Sipek Subject: Re: Is a NULL check missing in nfs_lookup? Date: Thu, 4 Jan 2007 20:59:30 -0500 Message-ID: <20070105015930.GC9192@filer.fsl.cs.sunysb.edu> References: <1167958054.5190.1.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Chaitanya Patti , linux-fsdevel@vger.kernel.org Return-path: Received: from filer.fsl.cs.sunysb.edu ([130.245.126.2]:46605 "EHLO filer.fsl.cs.sunysb.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030260AbXAECGT (ORCPT ); Thu, 4 Jan 2007 21:06:19 -0500 To: Shaya Potter Content-Disposition: inline In-Reply-To: <1167958054.5190.1.camel@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Jan 04, 2007 at 07:47:34PM -0500, Shaya Potter wrote: > yes, you're writing a stackable file system (the cs.sunysb gives that > away) and have run a lookup_one_len() on a nfs mounted file system and > that means nd is null. > > Erez's group is trying to fix that situation so the intents can be > passed correctly. If you look for the last Unionfs submission to lkml/fsdevel, one of the patches creates lookup_one_len_nd which allows you to pass a nameidata structure down to the lower filesystem. Beware, NFSv4 is cranky when it comes to lookup intents. In Unionfs, we have some additional lookup_one_len's in a number of places that have no nameidata that we can work off of, and that's causing quite a number of problems as NFSv4 gets confused when it doesn't see an intent. Josef "Jeff" Sipek. -- You measure democracy by the freedom it gives its dissidents, not the freedom it gives its assimilated conformists. - Abbie Hoffman