From: Brendan Cully Subject: Re: [PATCH 00 of 10] Teach xm save to checkpoint a Date: Tue, 9 Jan 2007 13:33:15 -0800 Message-ID: <20070109213315.GH6065@ventoux.cs.ubc.ca> References: <20061216000428.GA5951@ventoux.cs.ubc.ca> <458909EE.5030705@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <458909EE.5030705@lab.ntt.co.jp> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Yoshiaki Tamura Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Wednesday, 20 December 2006 at 19:01, Yoshiaki Tamura wrote: > Brendan: >=20 > Hi, my name is Yoshi Tamura, working for NTT Labs in Japan. > I tried your patches, and I liked your new feature to checkpoint a runn= ing=20 > domain. > I also tried your patches for live migration, but xc_linux_restore() on= the=20 > remote machine failed. > I track downed the problem and fixed it by modifying __xen_checkpoint()= in=20 > machine_reboot.c. Take a look at the following patch. > As far as I have tested, it works for both xm save -c and xm migrate=20 > =E2=80=93live. > Let me know if you have any comments or better idea. Hi Yoshi, sorry for the late reply - I went on vacation shortly after your post. I'm working on incorporating Keir's feedback at the moment, which seems to include your suggestion. I'll post a new patch series soon. By the way, how were you doing checkpointed live migration? Didn't the old and new domains fight over the network and block devices? > Regards, >=20 > Yoshi Tamura >=20 >=20 > Signed-off-by: Yoshi Tamura >=20 > diff -r 3bde632518a4 linux-2.6-xen-sparse/drivers/xen/core/machine_rebo= ot.c > 23:05:42 2006 -0800 > +++ b/linux-2.6-xen-sparse/drivers/xen/core/machine_reboot.c Wed Dec 20= =20 > 16:21:43 2006 +0900 > @@ -171,8 +171,6 @@ int __xen_suspend(void) >=20 > pre_suspend(); >=20 > - gnttab_checkpoint(); > - > /* > * We'll stop somewhere inside this hypercall. When it returns, > * we'll start resuming after the restore. > @@ -223,6 +221,8 @@ int __xen_checkpoint(void) >=20 > xenbus_lock(); >=20 > + gnttab_suspend(); > + > preempt_disable(); >=20 > mm_pin_all(); > @@ -257,6 +257,8 @@ int __xen_checkpoint(void) > } else { > post_checkpoint(); >=20 > + gnttab_resume(); > + > local_irq_enable(); >=20 > xenbus_unlock(); >=20 >=20 >=20