From: Andreas Gruenbacher Subject: Re: [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks Date: Wed, 7 Feb 2007 11:55:06 -0800 Message-ID: <200702071155.07295.agruen@suse.de> References: <20070205182213.12164.40927.sendpatchset@ermintrude.int.wirex.com> <20070207154332.GF10574@sequoia.sous-sol.org> <45C9FD8C.7020502@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Chris Wright , Stephen Smalley , Christoph Hellwig , Tony Jones , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, viro@zeniv.linux.org.uk To: Jeff Mahoney Return-path: In-Reply-To: <45C9FD8C.7020502@suse.de> Content-Disposition: inline Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wednesday 07 February 2007 08:25, Jeff Mahoney wrote: > Chris Wright wrote: > > * Andreas Gruenbacher (agruen@suse.de) wrote: > >> Reiserfs currently only marks the ".reiserfs_priv" directory as private, > >> but not the files below it -- how about the attached patch to fix that? > > > > I don't think that's right. Look at ->create or ->lookup. Both of those > > properly set the private flag. This patch looks like a step backwards, > > sprinkling the init in so many places. > > Yeah, this is exactly what happens. The flag is purposely only set once, > and then is inherited up the tree. That's much better. I take back the patch; sorry I overlooked that. Thanks, Andreas