From: Valerie Henson Subject: Fix(es) for ext2 fsync bug Date: Wed, 14 Feb 2007 11:54:54 -0800 Message-ID: <20070214195453.GB7521@nifty> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Can Sar , Junfeng Yang , Dawson Engler , Theodore Ts'o To: linux-fsdevel@vger.kernel.org Return-path: Received: from mga06.intel.com ([134.134.136.21]:43198 "EHLO orsmga101.jf.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932516AbXBNTy5 (ORCPT ); Wed, 14 Feb 2007 14:54:57 -0500 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Just some quick notes on possible ways to fix the ext2 fsync bug that eXplode found. Whether or not anyone will bother to implement it is another matter. Background: The eXplode file system checker found a bug in ext2 fsync behavior. Do the following: truncate file A, create file B which reallocates one of A's old indirect blocks, fsync file B. If you then crash before file A's metadata is all written out, fsck will complete the truncate for file A... thereby deleting file B's data. So fsync file B doesn't guarantee data is on disk after a crash. Details: http://www.stanford.edu/~engler/explode-osdi06.pdf Two possible solutions I can think of: * Rearrange order of duplicate block checking and fixing file size in fsck. Not sure how hard this is. (Ted?) * Keep a set of "still allocated on disk" block bitmaps that gets flushed whenever a sync happens. Don't allocate these blocks. Journaling file systems already have to do this. -VAL