From: David Miller Date: Mon, 26 Feb 2007 18:12:19 +0000 Subject: Re: sparc64 / bbc_i2c.c Message-Id: <20070226.101219.18306730.davem@davemloft.net> List-Id: References: <1171978032.18442.11.camel@lax.shef.ac.uk> <20070225044754.1d849a8d.akpm@linux-foundation.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: j.j.green@sheffield.ac.uk Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org From: "J.J.Green" Date: Sun, 25 Feb 2007 23:58:48 +0000 (GMT) > Hi Andrew > > > The code around there looks relatively unbuggy to me. Removing that > > remove_wait_queue() would be very bad - it would cause later stack > > corruption. > > > > msleep_interruptible() certainly shouldn't consume CPU like that. Do we > > know where the CPU time is being spent? The output of: > > > > readprofile -r > > sleep 10 > > readprofile -n -v -m /boot/System.map | sort -n -k 3 | tail -40 > > > > would tell us. > > As was mentioned in another reply, this message by > Joerg Friedrich > > http://lists.debian.org/debian-sparc/2007/02/msg00045.html > > gives a possible explanantion of where the time is going. > I applied the patch to the debian kernel sources for 2.6.18, > it applied cleanly and fixed the problem. I've added Joerg's patch to my tree and will push it into -stable as well. Reviewing this patch had been sitting deep in my backlog for weeks, I just never got around to it, sorry.