From: Jan-Bernd Themann Subject: Re: [PATCH 2/2] ehea: NAPI multi queue TX/RX path for SMP Date: Wed, 28 Feb 2007 10:23:16 +0100 Message-ID: <200702281023.17591.ossthema@de.ibm.com> References: <200702271732.51829.ossthema@de.ibm.com> <45E46208.3000003@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: Jeff Garzik , netdev , Christoph Raisch , Jan-Bernd Themann , linux-kernel , linux-ppc , Marcus Eder , Thomas Klein , Stefan Roscher To: Patrick McHardy Return-path: Received: from mtagate1.uk.ibm.com ([195.212.29.134]:56321 "EHLO mtagate1.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932077AbXB1J3b (ORCPT ); Wed, 28 Feb 2007 04:29:31 -0500 In-Reply-To: <45E46208.3000003@trash.net> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi, > > > > +static inline int ehea_hash_skb(struct sk_buff *skb, int num_qps) > > +{ > > + u32 tmp; > > + if ((skb->nh.iph->protocol == IPPROTO_TCP) > > + && skb->protocol == ETH_P_IP) { > > skb->protocol has network byte order. The ETH_P_IP test should also > logically come before checking the IP protocol. > fixed. > > + tmp = (skb->h.th->source + (skb->h.th->dest << 16)) % 31; > > Only locally generated packets have a valid h.th pointer. > good point. I'll fix that. I'll send a new patch set later today Thanks, Jan-Bernd