From: "Daniel P. Berrange" Subject: Re: [PATCH]: Documentation for xm block-attach Date: Fri, 9 Mar 2007 18:55:24 +0000 Message-ID: <20070309185524.GB19151@redhat.com> References: <45F1A940.7020702@redhat.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <45F1A940.7020702@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Chris Lalancette Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Mar 09, 2007 at 01:36:48PM -0500, Chris Lalancette wrote: > Attached is a simple patch to update the man page for xm block-attach. It > currently says to use "ro" or "rw" for the mode, when it seems, empirically, to > take "r" or "w" for the mode, respectively. Update the man page to reflect that. Hmm, this sounds like a bug in both the man page, and block-attach. It ought to be possible to configure disks with any of r w ro rw w! rw! ! The hotplug scripts normalize this down to just r w ! So the block-attach command should accept the former large set, and man page should reflect that too Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|