From: Adrian Bunk Subject: [RFC: 2.6.21 patch] fix sound/pci/ice1712/wtm.c:wtm_init() Date: Mon, 19 Mar 2007 10:24:38 +0100 Message-ID: <20070319092438.GL752@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailhub.stusta.mhn.de (mailout.stusta.mhn.de [141.84.69.5]) by alsa0.perex.cz (Postfix) with ESMTP id 0EC0424624 for ; Mon, 19 Mar 2007 10:24:35 +0100 (CET) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Clement Guedez Cc: Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jaroslav Kysela List-Id: alsa-devel@alsa-project.org The Coverity checker spotted this bogus for() loop that produces an array overrun. It seems what actually should be done is quite simple? Signed-off-by: Adrian Bunk --- sound/pci/ice1712/wtm.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) --- linux-2.6.21-rc3-mm2/sound/pci/ice1712/wtm.c.old 2007-03-19 01:29:23.000000000 +0100 +++ linux-2.6.21-rc3-mm2/sound/pci/ice1712/wtm.c 2007-03-19 01:33:06.000000000 +0100 @@ -489,23 +489,15 @@ static int __devinit wtm_init(struct snd_ice1712 *ice) { - static unsigned short stac_inits_prodigy[] = { - STAC946X_RESET, 0, - (unsigned short)-1 - }; - unsigned short *p; - /*WTM 192M*/ ice->num_total_dacs = 8; ice->num_total_adcs = 4; ice->force_rdma1 = 1; /*initialize codec*/ - p = stac_inits_prodigy; - for (; *p != (unsigned short)-1; p += 2) { - stac9460_put(ice, p[0], p[1]); - stac9460_2_put(ice, p[0], p[1]); - } + stac9460_put(ice, STAC946X_RESET, 0); + stac9460_2_put(ice, STAC946X_RESET, 0); + return 0; } ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV