From: Christoph Hellwig Subject: Re: [PATCH 3/17] locks: make ->lock release private data before returning in GETLK case Date: Fri, 6 Apr 2007 18:46:18 +0100 Message-ID: <20070406174618.GC32549@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@osdl.org, Trond Myklebust , Marc Eshel , linux-fsdevel@vger.kernel.org To: "J. Bruce Fields" Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:50169 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753778AbXDFRqW (ORCPT ); Fri, 6 Apr 2007 13:46:22 -0400 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Apr 05, 2007 at 07:40:53PM -0400, J. Bruce Fields wrote: > diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c > index f52cf5c..d557a51 100644 > --- a/fs/nfs/nfs4proc.c > +++ b/fs/nfs/nfs4proc.c > @@ -3019,6 +3019,8 @@ static int _nfs4_proc_getlk(struct nfs4_state *state, int cmd, struct file_lock > status = 0; > } > out: > + if (request->fl_ops) > + request->fl_ops->fl_release_private(request); Don't we know which fl_release_private instace we'll call and could do a direct call instead? Otherwise ok.