From: "J. Bruce Fields" Subject: Re: [PATCH 1/17] locks: trivial removal of unnecessary parentheses Date: Sun, 8 Apr 2007 14:37:11 -0400 Message-ID: <20070408183711.GB10331@fieldses.org> References: <20070406203004.2fdc5353.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@osdl.org, Trond Myklebust , Marc Eshel , linux-fsdevel@vger.kernel.org To: Stephen Rothwell Return-path: Received: from mail.fieldses.org ([66.93.2.214]:38685 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbXDHShV (ORCPT ); Sun, 8 Apr 2007 14:37:21 -0400 Content-Disposition: inline In-Reply-To: <20070406203004.2fdc5353.sfr@canb.auug.org.au> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Apr 06, 2007 at 08:30:04PM +1000, Stephen Rothwell wrote: > On Thu, 5 Apr 2007 19:40:51 -0400 "J. Bruce Fields" wrote: > > > > From: J. Bruce Fields - unquoted > > > > Remove some unnecessary parentheses. > > Please don't do this. It is unnecessary churn for zero gain. The gain is certainly very close to zero, but still seems positive (removing some visual clutter), and the churn doesn't seem likely to cause problems as long as we're touching the same lines in later patches anyway. I've no intention of launching any broad assault against unnecessary parentheses. --b.