From: Alasdair G Kergon Subject: Re: [2.6.22 PATCH 22/26] dm: bio list helpers Date: Wed, 9 May 2007 16:47:11 +0100 Message-ID: <20070509154711.GC18152@agk.fab.redhat.com> References: <20070508194845.GC24114@agk.fab.redhat.com> <20070508174159.7d78a275.akpm@linux-foundation.org> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20070508174159.7d78a275.akpm@linux-foundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Andrew Morton Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org, Heinz Mauelshagen List-Id: dm-devel.ids On Tue, May 08, 2007 at 05:41:59PM -0700, Andrew Morton wrote: > On Tue, 8 May 2007 20:48:45 +0100 > Alasdair G Kergon wrote: > > +#define BIO_LIST(bl) \ > > + struct bio_list bl = BIO_LIST_INIT > BIO_LIST is a strange name for something which initialises storage. Those came by analogy with list.h, with list_head -> bio_list: #define LIST_HEAD(name) \ struct list_head name = LIST_HEAD_INIT(name) We could use something like INIT_BIO_LIST(bl) for that, but perhaps it would be more readable always written out in full? struct bio_list bl = BIO_LIST_INIT; Alasdair -- agk@redhat.com