From: Andrew Morton Subject: Re: [2.6.22 PATCH 23/26] dm delay: Date: Thu, 10 May 2007 12:37:55 -0700 Message-ID: <20070510123755.09dbc70c.akpm@linux-foundation.org> References: <20070508194859.GD24114@agk.fab.redhat.com> <20070508175410.d5b7e91f.akpm@linux-foundation.org> <20070510120223.bb4c22df.akpm@linux-foundation.org> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Christoph Lameter Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org, Alasdair G Kergon , Heinz Mauelshagen List-Id: dm-devel.ids On Thu, 10 May 2007 12:04:50 -0700 (PDT) Christoph Lameter wrote: > On Thu, 10 May 2007, Andrew Morton wrote: > > > > > + delayed_cache = kmem_cache_create("dm-delay", > > > > + sizeof(struct delay_info), > > > > + __alignof__(struct delay_info), > > > > + 0, NULL, NULL); > > > > > > We have an ugly^Wnice new KMEM_CACHE macro for this now. > > How could I nicify the macro? Lower case? Lower case would be worse, IMO. Upper-case says "this is a macro". Lower-case macros are OK when they are macros pretending to be functions, but KMEM_CACHE is not such a thing. I don't think it can be nicified, except by removing it. We generally prefer to open-code things rather than wrapping them up in macros. But given the amount of variation amongst callers and the number of times this got screwed up, I agree that burying those details at a single site makes sense in this instance.