Date: Fri, 11 May 2007 18:21:43 +0200
From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Message-ID: <20070511162143.GA30863@aragorn>
References: <20070511160314.GA30111@aragorn> <20070511161134.GA30158@aragorn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070511161134.GA30158@aragorn>
Organization: free as in freedom
User-Agent: Mutt/1.5.13 (2006-08-11)
Subject: Re: [PATCH] grub-install for EFI
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>

On Fri, May 11, 2007 at 06:11:34PM +0200, Robert Millan wrote:
> 
> One thing that I'm not sure about is the CLI inconsistency.  Perhaps it
> shouldn't take the directory as a standalone parameter, and instead use
> --root-directory?

Or perhaps it should do like powerpc and check that /boot/grub is a mount
point?

# Find the partition at the right mount point.
install_device=`awk '$2 == '"\"$grubdir\""' { print $1 }' < /proc/mounts`
if test "x$install_device" = x; then
    echo "$grubdir must be a mount point."
    exit 1
fi

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.