From: Andrew Morton Date: Wed, 16 May 2007 00:29:57 +0000 Subject: Re: slab hang on boot Message-Id: <20070515172957.02d80d51.akpm@linux-foundation.org> List-Id: References: <20070515163321.744e2388.akpm@linux-foundation.org> <20070515165636.5057456e.akpm@linux-foundation.org> <20070515.171447.83623268.davem@davemloft.net> In-Reply-To: <20070515.171447.83623268.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: clameter@sgi.com, mroos@linux.ee, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 15 May 2007 17:14:47 -0700 (PDT) David Miller wrote: > From: Andrew Morton > Date: Tue, 15 May 2007 16:56:36 -0700 > > > On Tue, 15 May 2007 16:45:22 -0700 (PDT) > > Christoph Lameter wrote: > > > > > KMALLOC_SHIFT_HIGH is not a constant but may be less than 25. > > > > It darn well better be a compile-time constant. > > Try to define a compile-time array size with it smarty > pants :-) confusedy pants, more like. > That's what we did initially and it doesn't work. This: struct kmem_cache kmalloc_caches[KMALLOC_SHIFT_HIGH + 1] __cacheline_aligned; is still there.