From: "Yoshinori K. Okuji" <okuji@enbug.org>
Organization: enbug.org
To: The development of GRUB 2 <grub-devel@gnu.org>
Date: Tue, 15 May 2007 22:22:06 +0200
User-Agent: KMail/1.9.4
References: <20070511160314.GA30111@aragorn> <20070511161134.GA30158@aragorn>
	<20070511162143.GA30863@aragorn>
In-Reply-To: <20070511162143.GA30863@aragorn>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200705152222.06588.okuji@enbug.org>
Subject: Re: [PATCH] grub-install for EFI
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>

On Friday 11 May 2007 18:21, Robert Millan wrote:
> On Fri, May 11, 2007 at 06:11:34PM +0200, Robert Millan wrote:
> > One thing that I'm not sure about is the CLI inconsistency.  Perhaps it
> > shouldn't take the directory as a standalone parameter, and instead use
> > --root-directory?
>
> Or perhaps it should do like powerpc and check that /boot/grub is a mount
> point?
>
> # Find the partition at the right mount point.
> install_device=`awk '$2 == '"\"$grubdir\""' { print $1 }' < /proc/mounts`
> if test "x$install_device" = x; then
>     echo "$grubdir must be a mount point."
>     exit 1
> fi

It is a bad idea to use /proc, at least without checking the operating system. 
This makes the script unportable among host operating systems.

Okuji