Received: from 87-194-8-8.bethere.co.uk ([87.194.8.8] helo=aeryn.fluff.org.uk) by canuck.infradead.org with esmtps (Exim 4.63 #1 (Red Hat Linux)) id 1HsktR-0008UP-BU for linux-mtd@lists.infradead.org; Mon, 28 May 2007 15:28:39 -0400 Date: Mon, 28 May 2007 20:28:34 +0100 From: Ben Dooks To: linux-mtd@lists.infradead.org Subject: [PATCH] mtdcore.c: share syms with mtd_blkdev.c Message-ID: <20070528192834.GA13509@fluff.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Fix the sparse warnings generated by the implicit dependency of mtd_blkdevs.c and mtd_core.c for the two symbols mtd_table and mtd_table_mutex. This is done by adding an local header file mtdcore.h to define these (including the warning about the non-proliferation of these symbols). Signed-off-by: Ben Dooks --- linux-2.6.22-rc3/drivers/mtd/mtdcore.h 1970-01-01 01:00:00.000000000 +0100 +++ linux-2.6.22-rc3-sparse1/drivers/mtd/mtdcore.h 2007-05-28 20:14:13.000000000 +0100 @@ -0,0 +1,11 @@ +/* linux/drivers/mtd/mtdcore.h + * + * Header file for driver private mtdcore exports + * + */ + +/* These are exported solely for the purpose of mtd_blkdevs.c. You + should not use them for _anything_ else */ + +extern struct mutex mtd_table_mutex; +extern struct mtd_info *mtd_table[MAX_MTD_DEVICES]; diff -urpN -X linux-2.6.22-rc3-sparse1//Documentation/dontdiff linux-2.6.22-rc3-sparse1//drivers/mtd/mtd_blkdevs.c linux-2.6.22-rc3-sparse2/drivers/mtd/mtd_blkdevs.c --- linux-2.6.22-rc3-sparse1//drivers/mtd/mtd_blkdevs.c 2007-05-28 19:45:39.000000000 +0100 +++ linux-2.6.22-rc3-sparse2/drivers/mtd/mtd_blkdevs.c 2007-05-28 20:15:05.000000000 +0100 @@ -23,10 +23,9 @@ #include #include -static LIST_HEAD(blktrans_majors); +#include "mtdcore.h" -extern struct mutex mtd_table_mutex; -extern struct mtd_info *mtd_table[]; +static LIST_HEAD(blktrans_majors); struct mtd_blkcore_priv { struct task_struct *thread; diff -urpN -X linux-2.6.22-rc3-sparse1//Documentation/dontdiff linux-2.6.22-rc3-sparse1//drivers/mtd/mtdcore.c linux-2.6.22-rc3-sparse2/drivers/mtd/mtdcore.c --- linux-2.6.22-rc3-sparse1//drivers/mtd/mtdcore.c 2007-04-26 04:08:32.000000000 +0100 +++ linux-2.6.22-rc3-sparse2/drivers/mtd/mtdcore.c 2007-05-28 20:25:28.000000000 +0100 @@ -22,6 +22,8 @@ #include +#include "mtdcore.h" + /* These are exported solely for the purpose of mtd_blkdevs.c. You should not use them for _anything_ else */ DEFINE_MUTEX(mtd_table_mutex);