From: Bob Peterson Date: Thu, 10 Dec 2015 08:20:20 -0500 (EST) Subject: [Cluster-devel] [PATCH] mkfs.gfs2: Always validate the locktable option In-Reply-To: <1449752726-28341-1-git-send-email-anprice@redhat.com> References: <1449752726-28341-1-git-send-email-anprice@redhat.com> Message-ID: <2007062394.31800161.1449753620789.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Andy, The patch looks good. The only thing that caught my eye was that this statement looks kinda messy and could use a few more parentheses: (snip) > + if (strcmp(opts->lockproto, "lock_nolock") != 0 && !table_required) The logic looks right, but I usually add more parens than necessary, for clarity. Regards, Bob Peterson Red Hat File Systems