From: Adrian Bunk <bunk@stusta.de>
Subject: [2.6.23 patch] xenbus_xs.c: fix a use-after-free
Date: Mon, 23 Jul 2007 03:11:35 +0200
Message-ID: <20070723011135.GU26212@stusta.de>
References: <20070723010204.GT26212@stusta.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S933742AbXGWBMX@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20070723010204.GT26212@stusta.de>
Sender: linux-kernel-owner@vger.kernel.org
To: jeremy@xensource.com, chrisw@sous-sol.org
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
List-Id: xen-devel@lists.xenproject.org

This patch fixes an obvious use-after-free spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---
--- linux-2.6.22-rc6-mm1/drivers/xen/xenbus/xenbus_xs.c.old	2007-07-23 03:04:20.000000000 +0200
+++ linux-2.6.22-rc6-mm1/drivers/xen/xenbus/xenbus_xs.c	2007-07-23 03:04:42.000000000 +0200
@@ -782,8 +782,8 @@ static int process_msg(void)
 		msg->u.watch.vec = split(body, msg->hdr.len,
 					 &msg->u.watch.vec_size);
 		if (IS_ERR(msg->u.watch.vec)) {
-			kfree(msg);
 			err = PTR_ERR(msg->u.watch.vec);
+			kfree(msg);
 			goto out;
 		}